chore(ci): update github actions to latest version#1301
chore(ci): update github actions to latest version#1301jacobgkau merged 2 commits intosystem76:masterfrom
Conversation
| @@ -0,0 +1 @@ | |||
| nodejs 16.16.0 | |||
There was a problem hiding this comment.
Supports things like mise, asdf, and the setup-node action. This is the latest supported version of node that works (all of the dependencies are pretty out of date)
There was a problem hiding this comment.
We appeared to be using Node.js 18 in our local testing setup (a Nix shell) until today, and are now using Node.js 20. I see that the GitHub workflow used to use 14 and will now use 16. I'm not concerned about the version mismatch causing a problem since it already wasn't matching before, but I am confused if I'm comparing the right numbers or not. (Or maybe some dependencies that don't work with >16 versions aren't necessary for local builds but are for live deployment?)
| node-version-file: .tool-versions | ||
|
|
||
| - id: cache | ||
| name: Cache |
There was a problem hiding this comment.
Might as well use it everywhere since we already are using it below.
jacobgkau
force-pushed
the
actions-upgrade
branch
2 times, most recently
from
093fac0 to
08f629a
Compare
jacobgkau
force-pushed
the
actions-upgrade
branch
from
08f629a to
5c13bb7
Compare
jacobgkau
force-pushed
the
actions-upgrade
branch
from
5c13bb7 to
60e9ce0
Compare
jacobgkau
force-pushed
the
actions-upgrade
branch
from
60e9ce0 to
d2d3ced
Compare
.github/workflows/ci.yml
Outdated
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v2 | ||
| uses: actions/checkout@v4 |
There was a problem hiding this comment.
Checkout and setup node are both version 6 now. It doesn't look like there are any breaking changes for checkout@v6. There are some breaking changes with setup-node@v6. Could we try and update these latest versions? If we're already testing and updating this, then might as well go with the newest versions out at the time of release.
3 participants
This updates the GitHub actions to the latest version, uses cache everywhere (since it was already used a couple of places), and updates the deploy step to use actions instead of deploying via a git branch. This should improve clone performance a bit by not having an orphan with all of the images stored in git.
This will require you to change the github pages settings to deploy via "Github Actions" instead of "Deploy from a branch", and set the cname to
support.system76.com.https://github.com/system76/docs/settings/pages